@W-14758629@ SLAS Private Client Support #1722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sdk-private-slas W-14764021 - [commerce-sdk-react] Support private slas client
…1664) * Allow objects in commerceapi path * Add custom endpoint for SLAS. Works on public client * Get private client working * Remove console log * A more generic header replacement * Slas credentials from env vars * Add exclusions for some endpoints * Custom middleware in ssr.js * Add dependency * Private SLAS client handler in runtime * Update commerce-sdk-react with private client endpoint * Cleanup * Public client by default * more cleanup * Fix existing tests * Runtime tests- WIP * WIP test * Apply some PR feedback * Small refactor * Working tests * add getSlasEndpoint test * Lint * Change endpoint path and other minor adjustments * Don't start server if env var not set * Fix flaky test * Add option for customizing more endpoints with private client * Rename client secret env var * Bump up a test timeout
…1683) * Allow objects in commerceapi path * Add custom endpoint for SLAS. Works on public client * Get private client working * Remove console log * add private slas/private question * add private slas/private question * A more generic header replacement * Slas credentials from env vars * Add exclusions for some endpoints * add private slas/private question * Custom middleware in ssr.js * Add dependency * Private SLAS client handler in runtime * Update commerce-sdk-react with private client endpoint * Cleanup * Public client by default * more cleanup * Fix existing tests * Runtime tests- WIP * WIP test * Apply some PR feedback * Small refactor * Working tests * add getSlasEndpoint test * Lint * Change endpoint path and other minor adjustments * Don't start server if env var not set * Fix flaky test * Add option for customizing more endpoints with private client * Rename client secret env var * Bump up a test timeout * Update generator * Lint * Fix lint in generated projects * Add comments on the original app config file * Add templates for non-extensible projects * More detailed developer note --------- Co-authored-by: Alex Vuong <[email protected]>
* Allow objects in commerceapi path * Add custom endpoint for SLAS. Works on public client * Get private client working * Remove console log * add private slas/private question * add private slas/private question * A more generic header replacement * Slas credentials from env vars * Add exclusions for some endpoints * add private slas/private question * Custom middleware in ssr.js * Add dependency * Private SLAS client handler in runtime * Update commerce-sdk-react with private client endpoint * Cleanup * Public client by default * more cleanup * Fix existing tests * Runtime tests- WIP * WIP test * Apply some PR feedback * Small refactor * Working tests * add getSlasEndpoint test * Lint * Change endpoint path and other minor adjustments * Don't start server if env var not set * Fix flaky test * Add option for customizing more endpoints with private client * Rename client secret env var * Bump up a test timeout * Update generator * Lint * Fix lint in generated projects * Add comments on the original app config file * Add templates for non-extensible projects * Improve missing env var handling in remote environments * More detailed developer note * Remove brackets --------- Co-authored-by: Alex Vuong <[email protected]>
* Add header injection to custom proxy * Refactor to remove duplicate code
…private (#1696) * Replace SFRA->PWA session handoff logic * Merge branch 'feature/pwa-kit-slas-private-support' into private-client-hybrid * Remove console.logs * Adjust cookie name * Code refactor * Return empty string * Tests * Rework suffix of cookie chunks * Update more local storage values on SFRA token handoff * Test local storage update * Remove refresh token copies from local store * Remove refresh token copy references in test * Code cleanup
* Replace SFRA->PWA session handoff logic * Merge branch 'feature/pwa-kit-slas-private-support' into private-client-hybrid * Remove console.logs * Adjust cookie name * Code refactor * Return empty string * Tests * Rework suffix of cookie chunks * Update more local storage values on SFRA token handoff * Test local storage update * Remove refresh token copies from local store * Remove refresh token copy references in test * Enable PWA private client via boolean * Disable private client in template and update comments * Move placeholder to constants * Apply feedback * Update comment * Update comments --------- Signed-off-by: vcua-mobify <[email protected]>
…ate-client-e2e-ci
…-client-e2e-ci @W-14758651@ - Update E2E test workflow to test for PWA Kit with Private Clients
alexvuong
previously approved these changes
Mar 28, 2024
shethj
previously approved these changes
Mar 28, 2024
alexvuong
approved these changes
Apr 1, 2024
bendvc
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for merging in the SLAS Private Client feature branch onto develop.
This PR aggregates of the following PRs:
#1649 - Update commerce-sdk-react to support SLAS private clients
#1664 - Introduce middleware to inject SLAS client secrets to SLAS requests
#1683 - Update pwa-kit-create-app with options and templates for generating projects that are set up for private clients
#1679 - Error handling if PWA_KIT_SLAS_CLIENT_SECRET env var is not set
#1690 - Add proxy headers (ie. x-mobify) to SLAS calls
#1696 - Update hybrid session sharing to support private clients and reduce session chrun
#1704 - Toggle commerce-sdk-react SLAS private client mode using a boolean
#1714 - Run PWA Kit E2E tests against SLAS private clients in CI
Note: As part of #1714, the version has been bumped to
3.5-dev.1. Without this version bump, the e2e tests seem unable to use the updated pwa-kit-create-app that includes theretail-react-app-private-slas-client