-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build lalrpop
without lalrpop binary
#4107
Conversation
lalrpop
with cargo
maybe i'd better to find a better way to do it. |
0ce8f4b
to
8688111
Compare
lalrpop
with cargo
lalrpop
without lalrpop binary
@youknowone With more research, I know it can run the |
No, actually I recently added it as an optional dependency. @coolreader18 wanted to avoid lalrpop dependency from CI side. |
Ok, I see. Then I think it'll be the best if rust-lang/cargo#3126 seems able to implement my thought but it seems not resolved yet. At now, I'll make this pull request as draft because I'm not sure what is the solution 🤔 Current my thought is:
|
8688111
to
3c794b0
Compare
64fdc10
to
ca256d3
Compare
I opened again because @youknowone pushed ca256d3 commit and the CI seems passed well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for good idea
When I started to work on RustPython project today, I met compile error about
python.rs
. I guess it occurred because thepython.rs
, generated lalrpop file, was removed and it became to generate the file every compile. And the error message guided me to installlalrpop
by usingcargo install lalrpop
command.This pull request makes the
parser/build.rs
useslalrpop
crates instead oflalrpop
binary.You can test with the below commands: