FSB hash function #256

iquerejeta · 2021-04-24T09:05:07Z

As an exercise, I've implemented the FSB hash function taking as a reference the paper, so I might have missed out on some efficiency tricks in the reference implementation.

If you'd be happy to have this code in the repo, I'm happy to maintain it and make the necessary changes to take it to the repo quality standards!

tarcieri · 2021-05-03T14:28:04Z

.gitignore

+.idea
+.DS_Store


Speaking as a fellow IntelliJ user...

I'd suggest adding the following to your personal ~/.gitconfig instead:

[core] excludesfile = /home/myuser/.gitignore

...and then putting these kinds of directives in there.

That avoids every other project having to add .gitignore directives for every editor.

tarcieri · 2021-05-03T14:34:19Z

fsb/Cargo.toml

@@ -0,0 +1,16 @@
+[package]
+name = "fsb_rust"


RustCrypto owns the fsb name. You can use that.

@newpavlov can you add rustcrypto:hashes as an owner?

fsb/Cargo.toml

tarcieri · 2021-05-03T14:37:43Z

Looks like a promising start!

@iquerejeta can you rebase? You'll probably want to git checkout --theirs Cargo.lock and have it recomputed from there.

tarcieri · 2021-05-03T18:51:37Z

fsb/src/lib.rs

+#[allow(dead_code)]
+#[macro_use]
+mod macros;
+mod pi;


GitHub won't even let me leave comments on that module, but... wow 😮

Not my work! Copied that file from the reference implementation

tarcieri · 2021-05-03T18:54:24Z

@iquerejeta it looks like you need to bump clippy MSRV in .github/workflows/workspace.yml L19

Also can copy/modify a README.md from one of the other crates? (e.g. blake2) Thanks!

iquerejeta · 2021-05-03T19:26:53Z

I've rebased, hopefully correctly 😄

Missing the bump on clippy

qq, should I squash all commits to have a cleaner history?

tarcieri · 2021-05-03T21:44:51Z

We use GitHub's "Squash and merge" feature so you don't need to worry about squashing it yourself

iquerejeta · 2021-05-16T11:33:18Z

Bumped version. I got a security audit failing in the repo, but can't really tell what the problems are. Also I got a bunch of PRs from the bot, requesting to bump dependencies on other crates (e.g. sha1 or sha2). Should I go ahead and merge all these PRs?
Thanks!

tarcieri · 2021-05-26T23:30:04Z

Tests appear to be passing now.

newpavlov

I haven't checked the implementation itself, so I have only several surface-level comments for now.

newpavlov · 2021-05-27T08:30:34Z

.github/workflows/workspace.yml

@@ -16,7 +16,7 @@ jobs:
      - uses: actions/checkout@v1
      - uses: actions-rs/toolchain@v1
        with:
-          toolchain: 1.41.0 # MSRV
+          toolchain: 1.47.0 # MSRV


I think we can remove the "MSRV" comment from here, since it's not about MSRV, but about pinning clippy version.

newpavlov · 2021-05-27T08:32:09Z

Cargo.lock

@@ -81,6 +81,10 @@ dependencies = [
 "generic-array",
 ]

+[[package]]
+name = "fsb_rust"
+version = "0.1.0"


Since you've already changed the crate name, re-generate the lock file, so it will use fsb instead of fsb_rust? I have shared ownership of the fsb crate with the hashes group, so we can publish it immediately after merge.

newpavlov · 2021-05-27T08:35:06Z

fsb/Cargo.toml

+categories = ["cryptography", "no-std"]
+
+[dependencies]
+whirlpool = "0.9"


I suggest using whirlpool = { version = "0.9", path = "../whirlpool", default-features = false } here.

newpavlov · 2021-05-27T08:35:45Z

fsb/README.md

+[![crate][crate-image]][crate-link]
+[![Docs][docs-image]][docs-link]
+[![Build Status][build-image]][build-link]
+-->


Don't forget to uncomment these lines?

newpavlov · 2021-05-27T08:38:50Z

fsb/src/lib.rs

@@ -0,0 +1,21 @@
+#![allow(non_snake_case)]
+#[allow(dead_code)]
+#[macro_use]


Is it truly necessary to allow dead code? It also would be nice to add crate-level docs, no_std and other attributes (see other crates for reference).

added no_std, and I depend on alloc now for dynamically sized arrays. We use them here.

newpavlov · 2021-05-27T08:41:40Z

fsb/tests/lib.rs

+    assert_eq!(
+        result[..],
+        hex!("6e8ce7998e4c46a4ca7c5e8f6498a5778140d14b")[..]
+    );


You can simply use the following code here:

assert_eq!( Fsb160::digest(msg_1)[..], hex!("6e8ce7998e4c46a4ca7c5e8f6498a5778140d14b")[..], );

used for dynamically sized arrays

tarcieri · 2021-07-18T22:07:15Z

@iquerejeta thank you!

iquerejeta · 2021-07-19T07:43:25Z

Pleasure! I'm happy to change the tests using the use digest::new_test; macro, but when I tried it out I couldn't figure out how to generate the data (e.g. hashes/sha2/tests/data/sha256.blb), any tips?

iquerejeta mentioned this pull request May 2, 2021

Missing hash functions #1

Open

18 tasks

tarcieri reviewed May 3, 2021

View reviewed changes

fsb/Cargo.toml Outdated Show resolved Hide resolved

iquerejeta added 8 commits May 3, 2021 19:46

nothing worth mentioning

f3d81ac

IV changes

65def13

+1

80bde9c

missing only padding

0b98cdc

padding working, but ugly

8a4dfdd

retaking this alive

00f0698

Starting to write FSB with Digest.

7cbc661

compiled and ran, but test failing

9ca98ef

tarcieri reviewed May 3, 2021

View reviewed changes

iquerejeta and others added 9 commits May 3, 2021 19:55

failing test

4823a9b

still failing.. next step, debug with ref implementation

6c8418b

working! only with 160.

b917ee9

some cleaning

f2d6451

224 works as well, but need to solve macros

633d3ae

Fully working version

e7902d1

Delete fsbdoc.pdf

120eb7a

updated gitignore and Cargo

d787b9a

Added README--still some broken links

dddc078

iquerejeta force-pushed the master branch from 1d5cf79 to dddc078 Compare May 3, 2021 19:24

bumped MSRV

f54633c

newpavlov reviewed May 27, 2021

View reviewed changes

iquerejeta added 3 commits June 5, 2021 15:21

resolved flags

f9283fb

use of alloc for no_std

a9109b3

used for dynamically sized arrays

missed removing line

e1ba4db

tarcieri merged commit a1e8900 into RustCrypto:master Jul 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FSB hash function #256

FSB hash function #256

iquerejeta commented Apr 24, 2021

tarcieri May 3, 2021

tarcieri May 3, 2021

tarcieri commented May 3, 2021

tarcieri May 3, 2021

iquerejeta May 3, 2021

tarcieri commented May 3, 2021 •

edited

Loading

iquerejeta commented May 3, 2021 •

edited

Loading

tarcieri commented May 3, 2021

iquerejeta commented May 16, 2021 •

edited

Loading

tarcieri commented May 26, 2021

newpavlov left a comment

newpavlov May 27, 2021

newpavlov May 27, 2021

newpavlov May 27, 2021

newpavlov May 27, 2021

newpavlov May 27, 2021

iquerejeta Jun 5, 2021 •

edited

Loading

newpavlov May 27, 2021

tarcieri commented Jul 18, 2021

iquerejeta commented Jul 19, 2021

		.idea
		.DS_Store

FSB hash function #256

FSB hash function #256

Conversation

iquerejeta commented Apr 24, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarcieri commented May 3, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarcieri commented May 3, 2021 • edited Loading

iquerejeta commented May 3, 2021 • edited Loading

tarcieri commented May 3, 2021

iquerejeta commented May 16, 2021 • edited Loading

tarcieri commented May 26, 2021

newpavlov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iquerejeta Jun 5, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarcieri commented Jul 18, 2021

iquerejeta commented Jul 19, 2021

tarcieri commented May 3, 2021 •

edited

Loading

iquerejeta commented May 3, 2021 •

edited

Loading

iquerejeta commented May 16, 2021 •

edited

Loading

iquerejeta Jun 5, 2021 •

edited

Loading