Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove asm-related TODO comments #215

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Remove asm-related TODO comments #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d460dac
Remove asm-related TODO comments
newpavlov Jan 13, 2021
646ef9a
remove the last comment
newpavlov Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sha1/src/compress.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ cfg_if::cfg_if! {
mod aarch64;
use aarch64::compress as compress_inner;
} else if #[cfg(all(feature = "asm", any(target_arch = "x86", target_arch = "x86_64")))] {
// TODO: replace after sha1-asm rework
fn compress_inner(state: &mut [u32; 5], blocks: &[[u8; 64]]) {
for block in blocks {
sha1_asm::compress(state, block);
Expand Down
1 change: 0 additions & 1 deletion sha2/src/sha256.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ cfg_if::cfg_if! {
mod aarch64;
use aarch64::compress;
} else if #[cfg(all(feature = "asm", any(target_arch = "x86", target_arch = "x86_64")))] {
// TODO: replace after sha2-asm rework
fn compress(state: &mut [u32; 8], blocks: &[[u8; 64]]) {
for block in blocks {
sha2_asm::compress256(state, block);
Expand Down
1 change: 0 additions & 1 deletion sha2/src/sha256/aarch64.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ pub fn compress(state: &mut [u32; 8], blocks: &[[u8; 64]]) {
// TODO: Replace with https://github.com/rust-lang/rfcs/pull/2725
// after stabilization
if sha2_supported() {
// TODO: replace after sha2-asm rework
for block in blocks {
sha2_asm::compress256(state, block);
}
Expand Down
1 change: 0 additions & 1 deletion sha2/src/sha512.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ cfg_if::cfg_if! {
mod soft;
use soft::compress;
} else if #[cfg(all(feature = "asm", any(target_arch = "x86", target_arch = "x86_64")))] {
// TODO: replace after sha2-asm rework
fn compress(state: &mut [u64; 8], blocks: &[[u8; 128]]) {
for block in blocks {
sha2_asm::compress512(state, block);
Expand Down