-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Tensor struct #2
Conversation
@CameronMatthew can you have a look and see if this is heading in the right direction. Very rough around the edges (can you flatten an n-dimensional tensor in your head?), but that can be patched up with refinements to the API and maybe some additional macros. Also code is a bit of a mess (wth is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely along the right lines! This is very nice. One or two places you can make your life easier. Would also like to talk about reusing some of this for Static tensors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm very impressed by how quickly you managed to put this together!
I have restructured the code to have some of the features that we want. Namely I'm going to press ahead with some further restructurings:
I'm ignoring the specific implementations of the methods for now because they work (even if they are over-complicated). I will revisit them at the end and tidy them up as well as implement any of the other missing functionality. |
Would be good to have another review of the code written so far. I've implemented most of the methods outlined in #1 so far (missing more of the advanced features). Before I add any more, would like to get some feedback on the structure of everything. The way I've done it seems to work, but there's a fair bit of duplication. Perhaps there's a better way. Largely ignore the code within the methods for now. A lot of it needs to be looked at and refactored (unless you want to suggest a way to refactor it). They do get the job done though so 🤷 (I've never had more tests than I have for this repository I don't think ahaha). |
I had a quick look and seems fine. I think we should just merge this asap now. For the following reasons...
TL;DR Ship it 🚢! |
Sounds good to me. |
c911f59
to
3d9d9f4
Compare
3d9d9f4
to
d12849d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.