Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[NEW] message deletion syncing #2738

Closed
wants to merge 3 commits into from
Closed

[NEW] message deletion syncing #2738

wants to merge 3 commits into from

Conversation

AdamUncao
Copy link

@AdamUncao AdamUncao commented Jul 15, 2019

@RocketChat/ios

Added support for /api/v1/chat.getDeletedMessages in order to sync deleted messages
RoomDeletedMessagesRequest.swift taken from luismachado PR #2617

Closes #2208

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #2738 into develop will decrease coverage by 0.05%.
The diff coverage is 7.4%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2738      +/-   ##
===========================================
- Coverage    45.07%   45.01%   -0.06%     
===========================================
  Files          626      627       +1     
  Lines        28926    28980      +54     
===========================================
+ Hits         13039    13046       +7     
- Misses       15887    15934      +47
Impacted Files Coverage Δ
Rocket.Chat/Models/Subscription/Subscription.swift 51.02% <ø> (+2.04%) ⬆️
...API/Requests/Room/RoomDeletedMessagesRequest.swift 0% <0%> (ø)
...Chat/Controllers/Chat/MessagesViewController.swift 1.37% <0%> (-0.01%) ⬇️
Rocket.Chat/API/Clients/SubscriptionsClient.swift 59.01% <0%> (-7.04%) ⬇️
...cket.Chat/Controllers/Chat/MessagesViewModel.swift 38.42% <66.66%> (+0.37%) ⬆️
...s/Controllers/NotificationViewControllerSpec.swift 84.61% <0%> (ø) ⬆️
...lers/Notification/NotificationViewController.swift 54.87% <0%> (ø) ⬆️
...rs/Notification/TopTransparentViewController.swift 100% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dfc75c...f081eec. Read the comment docs.

@AdamUncao AdamUncao closed this Nov 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Visible all deleted/cleaned messages in channels
3 participants