-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for complex type parameter binding through FromUri #97
base: master
Are you sure you want to change the base?
Conversation
…client can handle it
…it to csproj not generate in tt file
@faniereynders FYI. |
@lust4life is there a way of fixing it? Ideally we would want he build to pass before merging the PR. Maybe we should create a Samples repo?? |
@faniereynders try a little,but appveyor‘s behavior makes me confused.finally just remove this sample project to make checks passed. |
great thanks @lust4life ! I will look at the changes in a bit. It's quite a lot 👍 In the meanwhile, I'm adding a samples repo over at https://github.com/WebApiProxy/samples. We need to get some samples going (also for POC purposes) so please could you upload your sample there in the respectable folder? |
don't forget add |
what exactly does |
add a pr for samples, the first two projects in samples can test this pr.
|
@lust4life dude you're a machine! 👍 |
@lust4life let's have a chat on https://gitter.im/WebApiProxy/vnext |
awesome~I really appreciate it. |
maybe add
w=1
(ignore whitespace) can makepr
compare more clearly.Add support for complex type parameter binding through FromUri
if our api controller has this signature:(you can find this in WebApiProxy.Api.Sample => TestController)
for those Action use ComplexModel and bind it FromUri, the current will generate code like this:
the name and age arguments will cause a compile error.
i support it like this :
and what we need to do is , find all
NotImplementedException
method, implement its client andoverride
it (GenerateGetFromComplexArgKeyValueList
) like this:after that , the client can process it correctly, i use a console project test it, here is the result and code .
here is the results:
thx for the work