Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation -> CSS -> Base -> Text Layout Helpers: Missing example for "{text-align}-{grid range}" and "{text-align}-{grid range}-only" #81

Closed
dirkeinecke opened this issue Nov 12, 2015 · 3 comments

Comments

@dirkeinecke
Copy link
Contributor

Documentation -> CSS -> Base -> Text Layout Helpers:
(http://responsivebp.com/css/base/#texthelpers)

Missing example for "{text-align}-{grid range}" and "{text-align}-{grid range}-only"

So nobody knows how to use this feature.

@JimBobSquarePants
Copy link
Member

Would you consider sending a pull request? I've got a link on each page entitled "Edit page on Github" which links to the respective file in the gh_pages branch.

So nobody knows how to use this feature.

I think that's a little strong. You're the first person to bring this up. The syntax follows the same structure as the layout helpers so I would have thought that would have been indicative to their functionality.

@dirkeinecke
Copy link
Contributor Author

General structure in the documentation:
{text-align}-{grid range}-only

Classes in the CSS file:

.text-xxs-push-only -> exists
.text-xs-push-only -> missing
.text-s-push-only -> missing
.text-m-push-only -> missing
.text-l-push-only -> missing

.text-xxs-push-only -> exists
.text-xs-push-only -> missing
.text-s-push-only -> missing
.text-m-push-only -> missing
.text-l-push-only -> missing

Example for general structure to real word values:

{text-align}-{grid range}-only
text-push-xxs-only

... but this does not match with the existing class text-xxs-push-only in the css file.

What is wrong? CSS file or documentation?

@JimBobSquarePants
Copy link
Member

Looks to me like you've uncovered a bug.

https://github.com/ResponsiveBP/Responsive/blob/master/src/sass/utilities/mixins/_text-align.scss#L74

The instructions there should all have the -only suffix. I'll get it updated asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants