Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "type" to EXCLUDE_KEYS in blocks serializer/deserializer #114

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

cekk
Copy link
Member

@cekk cekk commented Sep 4, 2024

This is needed to avoid code to convert "type" slate attribute value into an internal link.

slate set something like type: "link" and i had an edge-case where "link" was a content-id, so the attribute was converted in something like:

type:"http://mysite.com/link"

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10705043478

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 66.535%

Totals Coverage Status
Change from base Build 10680708577: 0.0%
Covered Lines: 1008
Relevant Lines: 1515

💛 - Coveralls

@luca-bellenghi luca-bellenghi merged commit ad1e154 into master Sep 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants