fix(health-index): add CSS custom prop to adjust z-index #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f4355e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +11 B (+0.01%) Total Size: 211 kB
ℹ️ View Unchanged
|
zeroedin
approved these changes
Oct 18, 2024
bennypowers
requested changes
Oct 27, 2024
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@rhds/elements": patch | |||
There was a problem hiding this comment.
this is a minor change
Can we fix this without exposing a new css property? in normal use, what would be the user story which would require them to be able to customize this z-index value?
Maybe we can solve this with position: relative on the host element?
There was a problem hiding this comment.
- this is only a problem in chrome
- I think we can fix this with
position: relative; z-index: 1on the container element, without requiring a minor release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
--rh-health-index-z-indexCSS custom prop to allow implementers to patch/adjust any z-index issues they may have with<rh-health-index>and other elements on the page.Quick solution to #1959