Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Minor design edit to rh-footer #392

Closed
coreyvickery opened this issue Jun 14, 2022 · 0 comments
Closed

[bug] Minor design edit to rh-footer #392

coreyvickery opened this issue Jun 14, 2022 · 0 comments
Assignees
@heyMP
Labels
bug Something isn't working for dev Ready for development

Comments

@coreyvickery
Copy link
Collaborator

Describe the bug

Description

  • Remove the horizontal rule from under the logo and social media icons on small screen sizes

Before

_Footer on small screens - before

After

_Footer on small screens - after

Which Component?

rh-footer

Steps to reproduce

Go here to see image examples or go here and play squishy window.

Expected behaviour

Horizontal rule should be not be visible on small screen sizes

Screenshots

No response

Element HTML

No response

Operating System (OS)

macOS

Browser

Chrome

More browser information

No response

Additional Info

No response
@coreyvickery coreyvickery added the bug Something isn't working label Jun 14, 2022
@methomps methomps added the for dev Ready for development label Jun 14, 2022
@heyMP heyMP moved this from Backlog to In Progress in Red Hat Design System Jun 23, 2022
heyMP added a commit that referenced this issue Jun 23, 2022
@heyMP
fix: remove header boarder on mobile
858b957 
fixes #392
@heyMP heyMP mentioned this issue Jun 23, 2022
Merged
5 tasks
@methomps methomps moved this from In Progress to Review in Red Hat Design System Jun 28, 2022
@heyMP heyMP closed this as completed in 58831e0 Jul 5, 2022
Repository owner moved this from Review to Done in Red Hat Design System Jul 5, 2022
@github-actions github-actions bot mentioned this issue Jul 5, 2022
Merged
@github-actions github-actions bot mentioned this issue Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heyMP heyMP

Labels
bug Something isn't working for dev Ready for development
Projects
Red Hat Design System
Status: Done ☑️
Milestone
No milestone
Development

No branches or pull requests
3 participants
@heyMP @coreyvickery @methomps