Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension to ScopedDisposable for SerialDisposable #873

Merged
merged 4 commits into from
Mar 18, 2024
Merged

Add extension to ScopedDisposable for SerialDisposable #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
862f7aa
Add extension to ScopedDisposable for SerialDisposable
sirnacnud Apr 17, 2023
90e7e86
Fix user name
sirnacnud Apr 17, 2023
623f11a
Merge branch 'master' into scoped-disposable-serial-disposable
sirnacnud Nov 27, 2023
97369fd
Merge branch 'master' into scoped-disposable-serial-disposable
mluisbrown Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
1. Fix minimum deployment target of iOS 11 in CocoaPods
1. Fix CI release git tag push trigger (#869, kudos to @p4checo)
1. Find and remove items from Bag using a binary search to improve performance when the collection gets large.
2. Add extension to `ScopedDisposable` for inner `SerialDisposable` (#873, kudos to @sirnacnud)

# 7.1.1
1. Bumped deployment target to iOS 11, tvOS 11, watchOS 4, macOS 10.13, per Xcode 14 warnings (#865, kudos to @lickel)
Expand Down
16 changes: 16 additions & 0 deletions Sources/Disposable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,3 +378,19 @@ public final class SerialDisposable: Disposable {
state.deinitialize()
}
}

extension ScopedDisposable where Inner == SerialDisposable {
/// The current inner disposable of the `SerialDisposable` wrapped
/// in the `ScopedDisposable` to dispose of.
///
/// Whenever this property is set (even to the same value!), the previous
/// disposable is automatically disposed.
public var inner: Disposable? {
get {
return inner.inner
}
set {
inner.inner = newValue
}
}
}
Loading