Version-guard STRING_PTR definition #6654
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6180. I'm not quite sure why the
#ifndef
approach failed us, but I confirmed this works, as well as confirming R 3.5.0 is the first version whereSTRING_PTR_RO()
is in a release:https://github.com/wch/r-source/blob/tags/R-3-4-4/src/include/Rinternals.h
https://github.com/wch/r-source/blob/tags/R-3-5-0/src/include/Rinternals.h