Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fill=Inf to sample full file for right fill guess #6203

Merged
merged 7 commits into from
Jun 30, 2024

Conversation

ben-schwen
Copy link
Member

@ben-schwen ben-schwen commented Jun 23, 2024

Closes #2727
Follow-up to #5119

  • fix
  • doc
  • news
  • tests

@ben-schwen ben-schwen marked this pull request as draft June 23, 2024 22:35
Copy link

github-actions bot commented Jun 23, 2024

Comparison Plot

Generated via commit df90e66

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 48 seconds

Time taken to run atime::atime_pkg on the tests: 3 minutes and 40 seconds

@ben-schwen ben-schwen marked this pull request as ready for review June 27, 2024 08:25
R/fread.R Outdated Show resolved Hide resolved
@tdhock
Copy link
Member

tdhock commented Jun 30, 2024

looks good to me, please merge

@ben-schwen ben-schwen merged commit 6621678 into master Jun 30, 2024
4 checks passed
@ben-schwen ben-schwen deleted the fill_sampleAll branch June 30, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not suggests fread fill=TRUE if already used
2 participants