Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setcolorder gains before= and after= #4691

Merged
merged 10 commits into from
Aug 26, 2021
Merged

Conversation

dracodoc
Copy link
Contributor

@dracodoc dracodoc commented Sep 2, 2020

This was based on discussion of #4668, #4358. I first implemented a version in #4669 , then found a better implementation from ben-schwen.

I closed my PR since ben-schwen's implementation is much better. After several weeks, seeing ben-schwen may not have time to create a PR and I want users be benefited from this convenient function earlier, I'm creating this PR using his implementation with full credit go to ben-schwen.

@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #4691 (4a52a89) into master (457fe7b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4691   +/-   ##
=======================================
  Coverage   99.53%   99.53%           
=======================================
  Files          76       76           
  Lines       14459    14467    +8     
=======================================
+ Hits        14392    14400    +8     
  Misses         67       67           
Impacted Files Coverage Δ
R/data.table.R 99.94% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 457fe7b...4a52a89. Read the comment docs.

@mattdowle mattdowle added this to the 1.14.1 milestone Aug 26, 2021
@mattdowle
Copy link
Member

@dracodoc Sorry for the long delay on this one. I was surprised you weren't a project member already: have invited you. What name do you prefer for the contributor list in DESCRIPTION? You don't have a name in your GitHub profile. You don't have to disclose your real name for DESCRIPTION, we can use an id there; there are two other ids there.

@mattdowle mattdowle changed the title Additional arguments for setcolorder: before, after setcolorder gains before= and after= Aug 26, 2021
@dracodoc
Copy link
Contributor Author

@mattdowle , Thanks for the invite, my name (Xianghui Dong) actually was added to contributor list long time ago :) Long time ago I made some improvements to the document when I first learned about data.table, then I had a code example for adding gzip support to fread using my work github id. Maybe my name was added from that code but I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants