-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setcolorder gains before= and after= #4691
Conversation
… columns before or after an anchor column
…inal value. Previously forgot to assign for default case
…olumns # Conflicts: # inst/tests/tests.Rraw
Codecov Report
@@ Coverage Diff @@
## master #4691 +/- ##
=======================================
Coverage 99.53% 99.53%
=======================================
Files 76 76
Lines 14459 14467 +8
=======================================
+ Hits 14392 14400 +8
Misses 67 67
Continue to review full report at Codecov.
|
@dracodoc Sorry for the long delay on this one. I was surprised you weren't a project member already: have invited you. What name do you prefer for the contributor list in DESCRIPTION? You don't have a name in your GitHub profile. You don't have to disclose your real name for DESCRIPTION, we can use an id there; there are two other ids there. |
@mattdowle , Thanks for the invite, my name (Xianghui Dong) actually was added to contributor list long time ago :) Long time ago I made some improvements to the document when I first learned about data.table, then I had a code example for adding gzip support to fread using my work github id. Maybe my name was added from that code but I'm not sure. |
This was based on discussion of #4668, #4358. I first implemented a version in #4669 , then found a better implementation from ben-schwen.
I closed my PR since ben-schwen's implementation is much better. After several weeks, seeing ben-schwen may not have time to create a PR and I want users be benefited from this convenient function earlier, I'm creating this PR using his implementation with full credit go to ben-schwen.