Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade CI to R 4.0 #4431

Merged
merged 4 commits into from
May 19, 2020
Merged

upgrade CI to R 4.0 #4431

merged 4 commits into from
May 19, 2020

Conversation

jangorecki
Copy link
Member

@jangorecki jangorecki commented May 6, 2020

closes #4406
.gitattributes partially address #3450 - it is needed so initial git checkout on windows uses proper newline (as is in the repository), not converting to windows because that invalidate fread tests of newline.


changes in our source dockerfiles

upgraded from ubuntu 16.04 to ubuntu 18.04

  • r-base-dev
  • r-builder
  • r-devel

upgraded from R 3.6 to R 4.0

  • r-base-dev
  • r-builder

changes in windows runners

  • private H2O windows CI runner machine has been replaced by public GitLab windows shared runners
  • r-release upgraded to R 4.0
  • r-devel now upgrades automatically

CI status: https://gitlab.com/jangorecki/data.table/pipelines/143350906

test-dev-win has 2 failed tests

test-dev-cran-lin has 1 failed tests

@jangorecki jangorecki requested a review from mattdowle May 6, 2020 13:13
@jangorecki jangorecki added the ci label May 6, 2020
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #4431 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4431      +/-   ##
==========================================
- Coverage   99.61%   99.60%   -0.01%     
==========================================
  Files          72       72              
  Lines       13917    13917              
==========================================
- Hits        13863    13862       -1     
- Misses         54       55       +1     
Impacted Files Coverage Δ
src/assign.c 99.84% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7609e...10a2e5a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade CI to R 4.0.0
2 participants