Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbindlist(..., fill=TRUE) fills missing list columns with NA instead of NULL #4199

Closed
wants to merge 2 commits into from

Conversation

sritchie73
Copy link
Contributor

Fix for #4198 , if desired.

Current behaviour:

> A = data.table(c1=0L, c2=list(1:3))
> B = data.table(c1=1:2)
> rbind(A,B,fill=TRUE)
      c1     c2
   <num> <list>
1:     0  1,2,3
2:     1   
3:     2

New behaviour:

> rbind(A,B,fill=TRUE)
      c1     c2
   <int> <list>
1:     0  1,2,3
2:     1     NA
3:     2     NA

@jangorecki
Copy link
Member

setting WIP till we agree on expected behaviour in related issue: #4198 (comment)

@jangorecki jangorecki added the WIP label Jan 25, 2020
@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #4199 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4199      +/-   ##
==========================================
+ Coverage   99.61%   99.61%   +<.01%     
==========================================
  Files          72       72              
  Lines       13871    13876       +5     
==========================================
+ Hits        13817    13822       +5     
  Misses         54       54
Impacted Files Coverage Δ
src/rbindlist.c 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c005296...5e5c4f7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants