Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first and last not load xts namespace when not needed #3859

Merged
merged 3 commits into from
Sep 12, 2019
Merged

first and last not load xts namespace when not needed #3859

merged 3 commits into from
Sep 12, 2019

Conversation

jangorecki
Copy link
Member

@jangorecki jangorecki commented Sep 11, 2019 •
edited by mattdowle
Loading

first on empty dt returns empty dt
closes #3857
closes #3858

we need a revdep re-run after merging this

@codecov
Copy link

codecov bot commented Sep 11, 2019 •
edited
Loading

Codecov Report

Merging #3859 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3859      +/-   ##
==========================================
+ Coverage   99.42%   99.42%   +<.01%     
==========================================
  Files          71       71              
  Lines       13425    13432       +7     
==========================================
+ Hits        13348    13355       +7     
  Misses         77       77
Impacted Files Coverage Δ
R/last.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b017347...511da69. Read the comment docs.

@mattdowle mattdowle changed the title first and last not load xts namespace when not needed, first on empty… first and last not load xts namespace when not needed Sep 12, 2019
@mattdowle mattdowle added this to the 1.12.4 milestone Sep 12, 2019
@mattdowle mattdowle merged commit 09aaac4 into master Sep 12, 2019
@mattdowle mattdowle deleted the last-xts branch September 12, 2019 00:56
@mattdowle
Copy link
Member

Merged to include in tonight's full revdep rerun #3581

@jangorecki jangorecki mentioned this pull request Nov 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.4
Development

Successfully merging this pull request may close these issues.

first on empty DT should return empty DT first / last POSIXct should not load xts namespace
2 participants
@jangorecki @mattdowle