Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip guess() step in dcast for fun.aggregate=length #3794

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Conversation

MichaelChirico
Copy link
Member

Closes #2980

@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #3794 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3794      +/-   ##
==========================================
+ Coverage   99.41%   99.41%   +<.01%     
==========================================
  Files          71       71              
  Lines       13225    13227       +2     
==========================================
+ Hits        13148    13150       +2     
  Misses         77       77
Impacted Files Coverage Δ
R/fcast.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4db0943...dead5cb. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #3794 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3794      +/-   ##
==========================================
+ Coverage   99.41%   99.41%   +<.01%     
==========================================
  Files          71       71              
  Lines       13244    13246       +2     
==========================================
+ Hits        13167    13169       +2     
  Misses         77       77
Impacted Files Coverage Δ
R/fcast.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 039088a...76c531f. Read the comment docs.

@mattdowle mattdowle added this to the 1.12.4 milestone Aug 30, 2019
@mattdowle mattdowle merged commit 88f036a into master Aug 30, 2019
@mattdowle mattdowle deleted the dcast_length branch August 30, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't warn about picking a value.var if fun.aggregate is explicitly length
2 participants