Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exported edit.data.table method #3773

Merged
merged 1 commit into from
Aug 28, 2019
Merged

exported edit.data.table method #3773

merged 1 commit into from
Aug 28, 2019

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Aug 18, 2019

Closes #593
Was doing due diligence & leaning towards just closing the issue without a fix but it's actually pretty easy.

@codecov
Copy link

codecov bot commented Aug 18, 2019

Codecov Report

Merging #3773 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3773   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files          71       71           
  Lines       13199    13199           
=======================================
  Hits        13122    13122           
  Misses         77       77
Impacted Files Coverage Δ
R/utils.R 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e926a...646c06d. Read the comment docs.

Copy link
Member

@jangorecki jangorecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattdowle mattdowle added this to the 1.12.4 milestone Aug 28, 2019
@mattdowle mattdowle changed the title Closes #593 -- added edit.data.table exported edit.data.table method Aug 28, 2019
@mattdowle mattdowle merged commit 2dbd3a0 into master Aug 28, 2019
@mattdowle mattdowle deleted the edit_data_table branch August 28, 2019 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[R-Forge #2489] edit() retaining class of data.table would be nice
3 participants