Fix case nrows=0 on a 1-row input #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdowle
reviewed
Jan 3, 2018
inst/tests/tests.Rraw
Outdated
| @@ -11233,6 +11233,7 @@ unlink(f) | |||
| # quoted fields followed by whitespace, #2520 | |||
| test(1858, fread('B,C\n"12" ,15\n"13" ,18\n"14" ,3'), data.table(B=c(12L, 13L, 14L), C=c(15L, 18L, 3L))) | |||
|
|
|||
| test(1859, fread("A\n", nrows=0), data.table(A=c(T))[0,]) # 2512 | |||
There was a problem hiding this comment.
Never use T in R. Always TRUE in full. The reason is that T is just a symbol in base. All symbols can be assigned any value, such as FALSE (!). In contrast, TRUE is a reserved symbol in the language itself: it is not possible to assign to or mask the symbol TRUE.
There was a problem hiding this comment.
thanks, good to know.
Codecov Report
@@ Coverage Diff @@
## master #2525 +/- ##
==========================================
+ Coverage 91.44% 91.45% +<.01%
==========================================
Files 63 63
Lines 12070 12071 +1
==========================================
+ Hits 11038 11039 +1
Misses 1032 1032
Continue to review full report at Codecov.
|
mattdowle
approved these changes
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2512