Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated two large test files and removed #2471

Merged
merged 1 commit into from
Nov 11, 2017

Conversation

mattdowle
Copy link
Member

Placed R code from issue #2275 into tests.Rraw to auto generate DT1 and DT2 rather than fread them in. Removed the need for stringi. The random data isn't exactly the same since stringi uses a different RNG I assume, but I don't think the particular seed matters in this case. Please check though.
To pass CRAN check note :

* checking installed package size ... NOTE
  installed size is  9.3Mb
  sub-directories of 1Mb or more:
    libs    1.1Mb
    tests   6.6Mb

due to these files from PR #2461 :

$ ls -lh inst/tests/issue_2275_dt*.csv
-rw-r--r-- 1 mdowle mdowle 1.7M Nov  8 12:31 inst/tests/issue_2275_dt1.csv
-rw-r--r-- 1 mdowle mdowle 2.7M Nov  8 12:31 inst/tests/issue_2275_dt2.csv

@codecov-io
Copy link

codecov-io commented Nov 8, 2017

Codecov Report

Merging #2471 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2471   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files          63       63           
  Lines       12031    12031           
=======================================
  Hits        11020    11020           
  Misses       1011     1011

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b8e886...177e5ad. Read the comment docs.

@arunsrinivasan
Copy link
Member

Thanks, Matt. I tried to reduce the size, but couldn't replicate the issue. I didn't realise the file was too big. I tested this data with the commit prior to the commit that fixed it and am able to reproduce the issue. So all good.

@arunsrinivasan arunsrinivasan merged commit 214d830 into master Nov 11, 2017
@mattdowle mattdowle deleted the issue_2275_generate_large_test_files branch November 13, 2017 18:57
@mattdowle mattdowle added this to the v1.10.6 milestone Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants