Closes #1973; lazyeval edge case of IDateTime caused an error in as.D… #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2062 +/- ##
==========================================
- Coverage 90.69% 90.58% -0.11%
==========================================
Files 59 58 -1
Lines 11431 11012 -419
==========================================
- Hits 10367 9975 -392
+ Misses 1064 1037 -27
Continue to review full report at Codecov.
|
…use output= of test() with a pattern
jangorecki
reviewed
Jun 25, 2017
| # IDateTime error when tzone is NULL, #1973 | ||
| x = as.POSIXct('2017-03-17') | ||
| attr(x, 'tzone') = NULL | ||
| test(1765, print(IDateTime(x)), output=".*idate.*itime.*1: 2017-03-17 00:00:00") |
There was a problem hiding this comment.
@MichaelChirico
This test on my machine produces:
Test 1765 didn't produce correct output:
> print(IDateTime(x))
Expected: '.*idate.*itime.*1: 2017-03-17 00:00:00'
Observed: ' idate itime1: 2017-03-16 00:00:00'
If timezone set to "Poland". If timezone set to "GB" test pass fine.
Poland is +1 hour vs GB so it shifts the date already. It should be fixed so users from various timezones can run tests.
> sessionInfo()
R version 3.4.0 (2017-04-21)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 16.04.2 LTS
Matrix products: default
BLAS: /usr/lib/libblas/libblas.so.3.6.0
LAPACK: /usr/lib/lapack/liblapack.so.3.6.0
locale:
[1] LC_CTYPE=en_GB.UTF-8 LC_NUMERIC=C
[3] LC_TIME=en_GB.UTF-8 LC_COLLATE=en_GB.UTF-8
[5] LC_MONETARY=en_GB.UTF-8 LC_MESSAGES=en_GB.UTF-8
[7] LC_PAPER=en_GB.UTF-8 LC_NAME=C
[9] LC_ADDRESS=C LC_TELEPHONE=C
[11] LC_MEASUREMENT=en_GB.UTF-8 LC_IDENTIFICATION=C
attached base packages:
[1] stats graphics grDevices utils datasets methods base
loaded via a namespace (and not attached):
[1] compiler_3.4.0
To reproduce set timezone on your workstation to Poland and run R check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ate.POSIXct
See discussion @ #1973. Quite a strange bug, not sure I fully wrap my head around how lazyeval is working here... may be that there's a better solution?