Skip to content

Commit

Permalink
remove check for unavailabe dependencies on ancient R (#6362)
Browse files Browse the repository at this point in the history
* add fixed version for old r version

* add versions

* add cran repo

* remove knitr from check

* add note about knitr

Co-authored-by: Michael Chirico <[email protected]>

* remove xts and add comment

* remove xts

* refine comment

---------

Co-authored-by: Michael Chirico <[email protected]>
  • Loading branch information
ben-schwen and MichaelChirico authored Aug 21, 2024
1 parent caacbbd commit d66e12b
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,15 @@ test-lin-dev-clang-cran:
# stated dependency on R
test-lin-ancient-cran:
image: registry.gitlab.com/jangorecki/dockerfiles/r-3.3.0
<<: *test-lin
image: registry.gitlab.com/jangorecki/dockerfiles/r-3.3.0
variables:
_R_CHECK_FORCE_SUGGESTS_: "FALSE" # can be removed if all dependencies are available (knitr, xts, etc.)
script:
- *install-deps
- R CMD check --no-manual $(ls -1t data.table_*.tar.gz | head -n 1)
# knitr requires evaluate, which requires R 3.6.0.

This comment has been minimized.

Copy link
@jangorecki

jangorecki Aug 23, 2024

Member

If we can render our vignettes with litedown instead then we could revert this as we won't need 3.6 anymore

# Restore checking vignettes if upgrading our R dependency means knitr can be installed.
- R CMD check --no-manual --no-build-vignettes --ignore-vignettes $(ls -1t data.table_*.tar.gz | head -n 1)

.test-win-template: &test-win
<<: *test
Expand Down

0 comments on commit d66e12b

Please sign in to comment.