Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.5 support #4527

Merged
merged 6 commits into from
Sep 27, 2019
Merged

Drop Python 3.5 support #4527

merged 6 commits into from
Sep 27, 2019

Conversation

ricwo
Copy link
Contributor

@ricwo ricwo commented Sep 27, 2019

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog
  • reformat files using black (please check Readme for instructions)

@ricwo ricwo requested a review from tmbo September 27, 2019 12:08
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 🚀 the future is now :D

CHANGELOG.rst Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
setup.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@tmbo tmbo requested review from a team and removed request for a team September 27, 2019 13:04
@ricwo ricwo merged commit 7a2b7c2 into master Sep 27, 2019
@ricwo ricwo deleted the drop-py-3.5 branch September 27, 2019 14:21
@TyDunn
Copy link
Contributor

TyDunn commented Sep 27, 2019

@akelad what docs updates do we need to make for this? (e.g. install instructions)

@tmbo
Copy link
Member

tmbo commented Sep 27, 2019

@ricwo good point, can you please do a search for 3.5 across the codebase? but I doubt it is mentioned anywhere but maybe readme and installation

@akelad
Copy link
Contributor

akelad commented Sep 27, 2019

yeah it's in the installation part for sure

@icaropires icaropires mentioned this pull request Sep 27, 2019
5 tasks
@ricwo
Copy link
Contributor Author

ricwo commented Sep 28, 2019

@tmbo I don't think there's another occurrence apart from the installation docs (I updated all others)

@tmbo
Copy link
Member

tmbo commented Sep 28, 2019

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop python 3.5 support
4 participants