Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML color picker, update p5.js #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ozgunozankilic
Copy link

Hi. I really liked your creation as an old Processing enthusiast and wanted to contribute.

  • The old color pickers are replaced with HTML color inputs. They still look the same from the outside, at least in Chrome, Firefox, Opera, Brave, and Tor Browser. It should work with Safari as well, but I could not test it.
    image
    Some styling changes were made accordingly and outlines are used instead of borders to achieve the same look. Cross-browser styling compatibility for the color input is a bit confusing, so the CSS additions might not be perfect. Color randomization still works on the old palette. Making the randomization a bit smarter may help with obtaining a more harmonious color scheme, but having those crazy and sometimes clashing colors might be intentional, so I did not change it. Perhaps a color shuffling button can be added?
  • Bottom padding is tweaked to improve the vertical alignment inside .brush and .setting. Here are the old and the new versions:
    image
  • p5.js is updated to v1.4.0 and everything seems fine.

scetchmachine-scream

The old 216-color color picker is replaced with HTML color input. padding-bottom of  "brush" and "setting" classes is increased to fix the vertical alignment in the UI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant