feat: log a warning instead of throwing an error for server host mismatch error #7236
Conversation
🦋 Changeset detectedLatest commit: 8a2a90e The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Varixo
force-pushed
the
v2-warn-server-mismatch-error
branch
from
8387e03 to
8a2a90e
Compare
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
| @@ -50,7 +50,6 @@ export const codeToText = (code: number, ...parts: any[]): string => { | |||
| "Element must have 'q:container' attribute.", // 42 | |||
| 'Unknown vnode type {{0}}.', // 43 | |||
| 'Materialize error: missing element: {{0}} {{1}} {{2}}', // 44 | |||
| 'SsrError: {{0}}', // 45 | |||
There was a problem hiding this comment.
You can't just delete a line here, each error must be on a single line so that error links work.
If you renumber all errors it's ok but once it's stable you shouldn't renumber any more. What you can do is use old numbers for new errors I suppose.
There was a problem hiding this comment.
yeah I know, it is alpha thats why I removed the error
| logWarn(errorMessage); | ||
| return null; | ||
| return 1; |
There was a problem hiding this comment.
this makes sorting unstable. If you don't see a difference, return 0.
There was a problem hiding this comment.
actually shouldn't we still sort by host depth?
and the warning should happen when ssrnodes that already streamed are marked dirty, not when tasks rerun, no?
There was a problem hiding this comment.
for some reason returning 0 is not working, I will look at it
Log a warning instead of throwing an error for server host mismatch error