Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chatMessage): update attributes display #1067

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

mamadoudicko
Copy link
Contributor

Description

Handle prompt or brain name missing

Screen.Recording.2023-08-30.at.16.17.04.mov

@mamadoudicko mamadoudicko temporarily deployed to preview August 30, 2023 14:19 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 2:27pm
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 2:27pm

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ChatMessages/index.tsx

The changes in this file are related to the ChatMessages component. The component is well structured and follows the SOLID principles. However, the inline styles could be moved to a CSS file or a styled component for better maintainability and reusability.

For example:

const chatContainerStyle = {
  display: 'flex',
  flexDirection: 'column',
  flex: 1,
  overflowY: 'auto',
};

// In the component
<div style={chatContainerStyle} ref={chatListRef}>

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/[chatId]/components/ChatMessages/components/ChatMessage/components/ChatMessage/ChatMessage.tsx

The changes in this file are related to the ChatMessage component. The component is well structured and follows the SOLID principles. However, the cn function is used to generate class names, which could be improved for readability. Consider using template literals for better readability.

For example:

const containerClasses = `\${isUserSpeaker ? 'bg-gray-100 bg-opacity-60 items-start' : 'bg-purple-100 bg-opacity-60 items-end'} py-3 px-5 w-fit dark:bg-gray-800 rounded-3xl flex flex-col overflow-hidden scroll-pb-32`;

📁💅👓


Powered by Code Review GPT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants