Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make chatlist scrollable #1064

Merged
merged 1 commit into from
Aug 30, 2023
Merged

feat: make chatlist scrollable #1064

merged 1 commit into from
Aug 30, 2023

Conversation

mamadoudicko
Copy link
Contributor

@mamadoudicko mamadoudicko commented Aug 30, 2023

Description

Make chatlist scrollable

Screen.Recording.2023-08-30.at.14.48.55.mov

@mamadoudicko mamadoudicko temporarily deployed to preview August 30, 2023 12:49 — with GitHub Actions Inactive
@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Aug 30, 2023 0:53am
quivrapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 0:53am

@github-actions
Copy link
Contributor

Risk Level 2 - /home/runner/work/quivr/quivr/frontend/app/chat/components/ChatsList/index.tsx

The code seems to be well written and follows the SOLID principles. However, there is a potential issue with the onDragEnd event handler. If the drag offset is exactly 100 or -100, the setOpen function will not be called which might not be the expected behavior. Consider adjusting the condition to include these edge cases. For example:

onDragEnd={(event, info) => {
  if (info.offset.x >= 100 && !open) {
    setOpen(true);
  } else if (info.offset.x <= -100 && open) {
    setOpen(false);
  }
}}

This will ensure that the setOpen function is called when the drag offset is exactly 100 or -100.


📝🐛🔧


Powered by Code Review GPT

@gozineb gozineb merged commit a6333ac into main Aug 30, 2023
StanGirard pushed a commit that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants