[MRG] add normalization of distances for WDA #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pr. Note that the tests failed because of pep8 violation that can be easily solved with autopep8. I will do a proper code review in the following days but note that the normalization should be an option in the function and be False by default to ensure that it will not break existing code. |
rflamary
reviewed
May 8, 2020
rflamary
changed the title
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
- Coverage 93.09% 92.94% -0.16%
==========================================
Files 20 20
Lines 4228 4237 +9
==========================================
+ Hits 3936 3938 +2
- Misses 292 299 +7 |
rflamary
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.