Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't promote vectors to matrices in dense layers #92

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Conversation

chriselrod
Copy link
Contributor

Closes #89

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #92 (4d2a78c) into main (3cda9f3) will increase coverage by 0.82%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   71.41%   72.23%   +0.82%     
==========================================
  Files          13       13              
  Lines        2316     2316              
==========================================
+ Hits         1654     1673      +19     
+ Misses        662      643      -19     
Impacted Files Coverage Δ
src/simple_chain.jl 87.09% <33.33%> (ø)
src/dense.jl 87.35% <100.00%> (+5.33%) ⬆️
src/forwarddiff_matmul.jl 88.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cda9f3...4d2a78c. Read the comment docs.

@chriselrod chriselrod merged commit 5a493d5 into main Jun 29, 2022
@chriselrod chriselrod deleted the vector2vector branch June 29, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants