More robust dual eval #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 71.41% 72.14% +0.72%
==========================================
Files 13 13
Lines 2316 2326 +10
==========================================
+ Hits 1654 1678 +24
+ Misses 662 648 -14
Continue to review full report at Codecov.
|
korsbo
reviewed
Jun 24, 2022
src/forwarddiff_matmul.jl
Outdated
| @@ -64,11 +64,26 @@ function dualeval!(f::F, Cdual::AbstractArray) where {F} | |||
| dualeval!(f, vec(Cdual)) | |||
| end | |||
| const MAX_NUM_LV_EXTRACT = isdefined(LoopVectorization, :EXTRACTFUNS) ? length(LoopVectorization.EXTRACTFUNS) : 14 | |||
| @generated function dualeval!( | |||
| _isstaticone(::One) = True() | |||
ChrisRackauckas
previously approved these changes
Jun 26, 2022
korsbo
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.