JS/JSX: Add support for recursive expressions #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another one worth refreshing for bundle size impacts. |
JS File Size Changes (gzipped)A total of 4 files have changed, with a combined diff of +261 B (+4.5%).
|
|
@RunDevelopment this looks really interesting, but I'm not sure how to help since a lot of it seems to be* out of date at this point. Do you think this is worth picking back up again? |
Not in its current form, no. This PR relies on a sorta hack to share regexes across languages. I'd rather wait for v2 where we can just directly import/export regexes via ESM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So after #2159 I wanted to add support for arbitrary JS spread expressions and kinda overdid it. I also added support for deeply nested expressions in JS template string interpolations.
Because I need very similar patterns in #2139, I decided that JS is going to share its patterns and added a way for languages to share internal patterns. It's done via a non-enumerable property
$. Because the property is non-enumerable, it won't be cloned (e.g. forextend) but it will be kept byinsertBefore.Btw. I'm not very attached to this version by variable sharing, so better ideas are very welcome.
Edit: Maybe we could do a
Prism.patternsfor globally shared patterns (RegExp or string)?This PR is a 3 in 1: JS Template strings, JSX spread expressions, and the
$property.