feat(api): add stacker module context and protocol command skeletons #17206
Conversation
ahiuchingau
force-pushed
the
EXEC-1079-module-context
branch
from
64c75d9 to
df3955a
Compare
| @@ -54,5 +59,5 @@ | |||
| "AbsorbanceReader", | |||
| "AbsorbanceReaderStatus", | |||
| "AbsorbanceReaderDisconnectedError", | |||
| "ModuleDisconnectedCallback", | |||
There was a problem hiding this comment.
This modules.ModuleDisconnectedCallback type got removed as the type has not been mported to this file, and hence, will not affect the rest of the code
ahiuchingau
force-pushed
the
EXEC-1079-module-context
branch
from
df3955a to
69c76de
Compare
ahiuchingau
force-pushed
the
EXEC-1079-module-context
branch
from
69c76de to
aef78d7
Compare
| stacker = self._equipment.get_module_hardware_api(stacker_substate.module_id) | ||
|
|
||
| if stacker is not None: | ||
| await stacker.dispense() |
There was a problem hiding this comment.
The signature of dispense has changed to dispense_labware(labware_height: float) so we must provide the labware height.
| stacker = self._equipment.get_module_hardware_api(stacker_substate.module_id) | ||
|
|
||
| if stacker is not None: | ||
| await stacker.store() |
There was a problem hiding this comment.
The signature of store has changed to store_labware(labware_height: float) so we must provide the labware height.
shared-data/command/schemas/11.json
Outdated
There was a problem hiding this comment.
Looks like this needs a top-level make format-js.
There was a problem hiding this comment.
Can we add unit tests for these new retrieve.py and store.py files? It doesn't have to happen in this PR if this is blocking something else, but I think it should happen soon, because we don't want to leave a window where complexity can grow and it ends up not being easily unit-testable when we finally do get around to it. I think that happened to the plate reader command, which gave us a bit of a hard time when we had to work on it recently.
Overview
This PR adds flex stacker support skeleton in the protocol engine.
TODO: add this so seth doesn't yell at me later