Remove calendar dates in RemoveOldCalendarStatements #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, I'm the new maintainer of this library. Do you think you could write a test for this? |
leonardehrenfried
force-pushed
the
master
branch
from
6aa1af3 to
3f0f297
Compare
tisseo-deploy
force-pushed
the
234-remove-calendar-dates
branch
from
4cb179d to
b010c96
Compare
tisseo-deploy
force-pushed
the
234-remove-calendar-dates
branch
from
b010c96 to
32c4502
Compare
tisseo-deploy
force-pushed
the
234-remove-calendar-dates
branch
from
32c4502 to
3e2ee06
Compare
|
Docs and tests OK, ready for review. |
Comment on lines
+364
to
+371
| Additionally, after truncating the calendar entries, it is recommended to use a **retain operation** to ensure that only trips with valid calendar dates are retained. | ||
|
|
||
| Without this retain operation, the `trips.txt` file will contain trips with non-existent calendar dates, leading to invalid data. | ||
|
|
||
| ``` | ||
| {"op":"transform", "class":"org.onebusaway.gtfs_transformer.impl.RemoveOldCalendarStatements", "remove_today":false} | ||
| {"op":"retain", "match":{"file":"calendar_dates.txt"}, "retainBlocks":false} | ||
| ``` |
There was a problem hiding this comment.
This is great documentation! ❤️
leonardehrenfried
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Solve Issue #234 : Remove calendar dates in RemoveOldCalendarStatements