Update setup-services.py #1398
Merged
Update setup-services.py #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker container name is mismatched from what is found in setup-services.py so the tests cant run without this fix.
|
Hey @spacetimeengineer - Thanks for the PR. What OS do you use? This is something I've run into on my machine (MacOS) but it does not seem to occur all the time for others. Seems that the tests have run fine on Linux. Let me ask someone in my group who uses Windows to give this a try, and then we can merge this. |
|
Hi Wu-Jung, So I was using PopOS 22.04 when I found the issue.
…On Fri, Oct 25, 2024, 11:38 Wu-Jung Lee ***@***.***> wrote:
Hey @spacetimeengineer <https://github.com/spacetimeengineer> - Thanks
for the PR. What OS do you use? This is something I've run into on my
machine (MacOS) but it does not seem to occur all the time for others.
Seems that the tests have run fine on Linux. Let me ask someone in my group
who uses Windows to give this a try, and then we can merge this.
—
Reply to this email directly, view it on GitHub
<#1398 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA26MX5YCSYU4U633A7J2VTZ5JQZDAVCNFSM6AAAAABQTQY6O6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZYGE2TENRXHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Ok, great. @brandynlucca reported back that this work on Windows, and I just tested on MacOS too. I'll get this merged! :) |
leewujung
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker container name is mismatched from what is found in setup-services.py so the tests cant run without this fix.