Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] contract_variable_qty_timesheet: Migration to version 17.0 #1104

Merged
merged 13 commits into from
Aug 24, 2024
Merged

[17.0][MIG] contract_variable_qty_timesheet: Migration to version 17.0 #1104

merged 13 commits into from
Aug 24, 2024

Conversation

juanjosesegui-tecnativa
Copy link
Contributor

@juanjosesegui-tecnativa juanjosesegui-tecnativa commented Jul 25, 2024 •
edited
Loading

@Tecnativa TT50112

@juanjosesegui-tecnativa juanjosesegui-tecnativa force-pushed the 17.0-mig-contract_variable_qty_timesheet branch 4 times, most recently from a10d292 to 7d00ca0 Compare August 7, 2024 08:42
carolinafernandez-tecnativa
carolinafernandez-tecnativa reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash administrative commits.

When pressing button Send by email i got this error message:

image

When creating invoices i got error message

image

Im not being able to add formula as it not editable for any qty variable option

contract_variable_qty_timesheet/readme/USAGE.md Outdated
@@ -0,0 +1,9 @@
To use this module, you need to:

1. Go to Invoicing \> Sales \> Contracts and select or create a new
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be: Go to Invoicing > Customers > Customers Contracts

@pedrobaeza pedrobaeza mentioned this pull request Aug 13, 2024
Merged
@danypr92
Copy link
Contributor

When pressing button Send by email i got this error message:
image

When creating invoices i got error message
image

Im not being able to add formula as it not editable for any qty variable option

I cannot reproduce these errors in a Runboat instance of this PR. I cannot choose a formula in the invoice line when the variable quantity option is selected, but I can see the formulas created in the Formulas (quantity) menu entry.

@carolinafernandez-tecnativa, please provide more details or the Runboat instance you are using. Additionally, could you specify if there are any changes in the process since version 16.0?

Thanks!

@juanjosesegui-tecnativa juanjosesegui-tecnativa force-pushed the 17.0-mig-contract_variable_qty_timesheet branch from 7d00ca0 to 435e0d7 Compare August 16, 2024 08:11
@juanjosesegui-tecnativa
Copy link
Contributor Author

juanjosesegui-tecnativa commented Aug 16, 2024 •
edited
Loading

When pressing button Send by email i got this error message:
image
When creating invoices i got error message
image
Im not being able to add formula as it not editable for any qty variable option

I cannot reproduce these errors in a Runboat instance of this PR. I cannot choose a formula in the invoice line when the variable quantity option is selected, but I can see the formulas created in the Formulas (quantity) menu entry.

@carolinafernandez-tecnativa, please provide more details or the Runboat instance you are using. Additionally, could you specify if there are any changes in the process since version 16.0?

Thanks!

Hello @danypr92 , the "send by email" error was caused by the "contract" module.
#1119

Some changes were missing in the "contract_variable_quantity" module. Try again and you will see that the formulas can now be selected.

@juanjosesegui-tecnativa juanjosesegui-tecnativa force-pushed the 17.0-mig-contract_variable_qty_timesheet branch from 435e0d7 to 834fe80 Compare August 19, 2024 10:01
@pedrobaeza
Copy link
Member

/ocabot migration contract_variable_qty_timesheet

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 19, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 19, 2024
Open
12 tasks
@juanjosesegui-tecnativa juanjosesegui-tecnativa force-pushed the 17.0-mig-contract_variable_qty_timesheet branch 2 times, most recently from 1a8d012 to a4450e5 Compare August 20, 2024 10:16
@juanjosesegui-tecnativa
Copy link
Contributor Author

All changes have been made and the administrative commits are squashed

ping @carolinafernandez-tecnativa

carolinafernandez-tecnativa
carolinafernandez-tecnativa approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM Thanks :)

@juanjosesegui-tecnativa juanjosesegui-tecnativa force-pushed the 17.0-mig-contract_variable_qty_timesheet branch from a4450e5 to 7d42bbd Compare August 21, 2024 07:40
danypr92
danypr92 approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@danypr92 danypr92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

carlosdauden and others added 9 commits August 24, 2024 18:51
@carlosdauden @pedrobaeza
[IMP] contract_variable_qty_timesheet: New module
5bd43ba
@primes2h @pedrobaeza
Added translation using Weblate (Italian)
0af2ee7 
Currently translated at 66.7% (2 of 3 strings)

Translation: contract-11.0/contract-11.0-contract_variable_qty_timesheet
Translate-URL: https://translation.odoo-community.org/projects/contract-11-0/contract-11-0-contract_variable_qty_timesheet/it/
@marylla @pedrobaeza
Added translation using Weblate (German)
411eac3 
Currently translated at 100.0% (3 of 3 strings)

Translation: contract-11.0/contract-11.0-contract_variable_qty_timesheet
Translate-URL: https://translation.odoo-community.org/projects/contract-11-0/contract-11-0-contract_variable_qty_timesheet/de/
@pedrobaeza
[MIG] contract_variable_qty_timesheet: Migration to 12.0
98fc2e9 
* Standard procedure
* README by fragments
* Promoted to Production/Stable and declared maintainers
* Code adapted to v12
* Tests added
@marcelsavegnago @pedrobaeza
Translated using Weblate (Portuguese (Brazil))
a3ab79b 
Currently translated at 66.7% (2 of 3 strings)

Translation: contract-12.0/contract-12.0-contract_variable_qty_timesheet
Translate-URL: https://translation.odoo-community.org/projects/contract-12-0/contract-12-0-contract_variable_qty_timesheet/pt_BR/
@pedrocs-exo @pedrobaeza
Added translation using Weblate (Portuguese)
f098de7
@pedrobaeza
[IMP] contract_variable_qty_timesheet: black, isort
50476c8
@pedrobaeza
[MIG][13.0] contract_variable_qty_timesheet: Migration to 13.0
e3d70f3
@rousseldenis @pedrobaeza
[13.0][ADD] copier
5eb32d0
@carolinafernandez-tecnativa @pedrobaeza
[MIG] contract_variable_qty_timesheet: Migration to 15.0
d16adf0 
[UPD] Update contract_variable_qty_timesheet.pot
[BOT] post-merge updates
Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-15.0/contract-15.0-contract_variable_qty_timesheet
Translate-URL: https://translation.odoo-community.org/projects/contract-15-0/contract-15-0-contract_variable_qty_timesheet/
@danypr92 @pedrobaeza
[MIG] contract_variable_qty_timesheet: Migration to 16.0
11e0a52
@juanjosesegui-tecnativa @pedrobaeza
[IMP] contract_variable_qty_timesheet: pre-commit auto fixes
9e54e48
@juanjosesegui-tecnativa @pedrobaeza
[MIG] contract_variable_qty_timesheet: Migration to 17.0
fbf05ba 
TT50112
@pedrobaeza pedrobaeza force-pushed the 17.0-mig-contract_variable_qty_timesheet branch from 7d42bbd to fbf05ba Compare August 24, 2024 16:54
pedrobaeza
pedrobaeza approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit history was still wrong. I have fixed it myself and push.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1104-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d829b67 into OCA:17.0 Aug 24, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2d798bc. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-contract_variable_qty_timesheet branch August 24, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolinafernandez-tecnativa carolinafernandez-tecnativa carolinafernandez-tecnativa approved these changes

@danypr92 danypr92 danypr92 approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.