[17.0][MIG] subscription_oca: Migration to 17.0 #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 95.7% (159 of 166 strings) Translation: contract-16.0/contract-16.0-subscription_oca Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-subscription_oca/nl/
Tisho99
force-pushed
the
17.0-mig-subscription_oca
branch
5 times, most recently
from
655a921 to
7f613c7
Compare
|
@pedrobaeza do you mind assigning this migration to @Tisho99 and close #1068 ? We'll finish this. |
Tisho99
force-pushed
the
17.0-mig-subscription_oca
branch
from
7f613c7 to
7095a9a
Compare
|
@HaraldPanten @ValentinVinagre PR ready for review |
Tisho99
force-pushed
the
17.0-mig-subscription_oca
branch
from
7095a9a to
f32e0a2
Compare
|
/ocabot migration subscription_oca |
| @@ -62,10 +62,10 @@ def _compute_subtotal(self): | |||
| ) | |||
|
|
|||
| price_subtotal = fields.Monetary( | |||
| string="Subtotal", readonly="True", compute=_compute_subtotal, store=True | |||
| string="Subtotal", readonly=True, compute="_compute_subtotal", store=True | |||
There was a problem hiding this comment.
@Tisho99 With this change, you can put fields definitions on top.
Tisho99
force-pushed
the
17.0-mig-subscription_oca
branch
from
f32e0a2 to
61c7521
Compare
|
@rousseldenis Could we merge, then? THX! |
Tisho99
force-pushed
the
17.0-mig-subscription_oca
branch
from
61c7521 to
f4e1dc6
Compare
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 1cd818b. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration
Supersedes #1068
T-6329