Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] contract: Migration to 17.0 #1024

Closed
wants to merge 1 commit into from
Closed

[17.0][MIG] contract: Migration to 17.0 #1024

wants to merge 1 commit into from

Conversation

peluko00
Copy link
Contributor

@peluko00 peluko00 commented Dec 5, 2023

No description provided.

@peluko00 peluko00 mentioned this pull request Dec 5, 2023
Open
12 tasks
angelmoya
angelmoya reviewed Dec 29, 2023
View reviewed changes
contract/__manifest__.py Outdated

{
"name": "Recurring - Contracts Management",
"version": "16.0.1.1.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change version, please

@fkantelberg fkantelberg mentioned this pull request Jan 4, 2024
Merged
@pedrobaeza
Copy link
Member

Please include #1026 and put the CI green if you want this to be reviewed.

@wpichler
Copy link
Contributor

wpichler commented Jan 22, 2024 •
edited
Loading

@peluko00 Could it be that you forgot to commit something ? The current state is not installable...

@rousseldenis
Copy link
Contributor

/ocabot migration contract

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jan 22, 2024
@rousseldenis
Copy link
Contributor

@peluko00 Could you follow https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0#technical-method-to-migrate-a-module-from-160-to-170-branch ? Thanks

@victoralmau
Copy link
Member

Please, include #1042

@jaydeep32
Copy link
Contributor

jaydeep32 commented Feb 9, 2024 •
edited
Loading

I have recently made many changes from this branch migrated module. I added those #1026 and #1042 in my code with migrated test cases.
I want to push this PR but need help getting a 403 error.
Could you allow me or guide me on how I can upload my change to this PR, or should I make one?

@pedrobaeza
Copy link
Member

@jaydeep32 you need to open a new pull request from your fork. As @peluko00 seems to not answer, we will supersede this one with yours if it's correct. Please also include #1033 (properly maintaining attribution for each commit).

@APSL APSL closed this by deleting the head repository Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelmoya angelmoya angelmoya left review comments

Assignees
No one assigned
Labels
migration needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
9 participants
@peluko00 @pedrobaeza @wpichler @rousseldenis @victoralmau @jaydeep32 @angelmoya @APSL @OCA-git-bot