Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging-next] microsoft-gsl: don't use -Werror for clang #367310

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Dec 22, 2024

https://hydra.nixos.org/build/281964532

filed upstream issue microsoft/GSL#1178 but for version 4.1.0 -- issue is gtest and c++14 (and -Werror) and they use an older gtest that still maintains c++14 support

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@paparodeo
Copy link
Contributor Author

rebuild count:

{
  "darwin": 44,
  "linux": 0
}

@ofborg ofborg bot requested a review from thoughtpolice December 22, 2024 20:12
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 22, 2024
@vcunat vcunat merged commit 83468da into NixOS:staging-next Dec 23, 2024
73 of 74 checks passed
@paparodeo paparodeo deleted the gsl-no-werror branch December 23, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants