Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mate.libmatekbd: build with meson, fix cross compilation #330713

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Jul 28, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: mate The MATE Desktop Environment label Jul 28, 2024
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jul 28, 2024
@ofborg ofborg bot requested review from romildo and bobby285271 July 28, 2024 21:26
@NickCao
Copy link
Member Author

NickCao commented Jul 31, 2024

Result of nixpkgs-review pr 330713 run on x86_64-linux 1

51 packages built:
  • ayatana-indicator-display
  • ayatana-indicator-session
  • blueberry
  • cinnamon-common
  • cinnamon-gsettings-overrides
  • cinnamon-screensaver
  • cinnamon-session
  • hypnotix
  • lightdm-slick-greeter
  • mate.libmatekbd
  • mate.marco
  • mate.mate-applets
  • mate.mate-control-center
  • mate.mate-gsettings-overrides
  • mate.mate-indicator-applet
  • mate.mate-media
  • mate.mate-netbook
  • mate.mate-notification-daemon
  • mate.mate-panel
  • mate.mate-panel-with-applets
  • mate.mate-power-manager
  • mate.mate-screensaver
  • mate.mate-sensors-applet
  • mate.mate-session-manager
  • mate.mate-settings-daemon
  • mate.mate-settings-daemon-wrapped
  • mate.mate-tweak
  • mate.mate-tweak.dist
  • mate.mate-utils
  • mate.mate-wayland-session
  • nemo
  • nemo-fileroller
  • nemo-python
  • nemo-with-extensions
  • nemo.dev
  • pix
  • plata-theme
  • python311Packages.python-xapp
  • python312Packages.python-xapp
  • sticky
  • timeshift
  • timeshift-minimal
  • timeshift-unwrapped
  • warpinator
  • xapp
  • xapp.dev
  • xed-editor
  • xmonad_log_applet_mate
  • xplayer
  • xreader
  • xviewer

@ofborg ofborg bot requested a review from bobby285271 July 31, 2024 02:20
Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperSandro2000 SuperSandro2000 merged commit e6f02f6 into NixOS:master Jul 31, 2024
25 of 27 checks passed
@NickCao NickCao deleted the libmatekbd branch July 31, 2024 15:09
@bobby285271
Copy link
Member

bobby285271 commented Jul 31, 2024

We probably should report to upstream about missing glib-compile-schemas post install script 🙃

Update:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: mate The MATE Desktop Environment 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants