-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jansson: enable shared library installation #177063
Conversation
Without shared libraries metworkmanager fails to build: $ nix build -f. networkmanager -L ... networkmanager> meson.build:269:2: ERROR: Assert failed: Unable to determine Jansson SONAME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Backport failed for Please cherry-pick the changes locally. git fetch origin release-22.05
git worktree add -d .worktree/backport-177063-to-release-22.05 origin/release-22.05
cd .worktree/backport-177063-to-release-22.05
git checkout -b backport-177063-to-release-22.05
ancref=$(git merge-base d07b20daf3b496bfd9121c67eefb504e26ca7ac6 938f2ce1017ff1fdb25abec3f22a0821618af8cb)
git cherry-pick -x $ancref..938f2ce1017ff1fdb25abec3f22a0821618af8cb |
Well the backport is trivial, but I'm waiting for confirmation that the version update really should be backported. |
Successfully created backport PR #177956 for |
I backported it because it's mostly an expression rewrite, which would help automatizing backports with labels. |
I wasn't sure at a quick glance, with the way version number changed, and I'm not familiar with implications of symbol versioning in libs. |
Without shared libraries metworkmanager fails to build:
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes