Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jansson: enable shared library installation #177063

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jun 9, 2022

Without shared libraries metworkmanager fails to build:

$ nix build -f. networkmanager -L
...
networkmanager> meson.build:269:2: ERROR: Assert failed: Unable to determine Jansson SONAME
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Without shared libraries metworkmanager fails to build:

    $ nix build -f. networkmanager -L
    ...
    networkmanager> meson.build:269:2: ERROR: Assert failed: Unable to determine Jansson SONAME
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@marsam marsam merged commit 8448f7e into NixOS:staging Jun 9, 2022
@trofi trofi deleted the shared-jansson branch June 9, 2022 20:06
@github-actions
Copy link
Contributor

Backport failed for release-22.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-22.05
git worktree add -d .worktree/backport-177063-to-release-22.05 origin/release-22.05
cd .worktree/backport-177063-to-release-22.05
git checkout -b backport-177063-to-release-22.05
ancref=$(git merge-base d07b20daf3b496bfd9121c67eefb504e26ca7ac6 938f2ce1017ff1fdb25abec3f22a0821618af8cb)
git cherry-pick -x $ancref..938f2ce1017ff1fdb25abec3f22a0821618af8cb

@vcunat
Copy link
Member

vcunat commented Jun 16, 2022

Well the backport is trivial, but I'm waiting for confirmation that the version update really should be backported.

@github-actions
Copy link
Contributor

Successfully created backport PR #177956 for staging-22.05.

@marsam
Copy link
Contributor

marsam commented Jun 17, 2022

I backported it because it's mostly an expression rewrite, which would help automatizing backports with labels.
I've checked the changes and it didn't contain any breaking change, except for this missing cmakeflag.

@vcunat
Copy link
Member

vcunat commented Jun 17, 2022

I wasn't sure at a quick glance, with the way version number changed, and I'm not familiar with implications of symbol versioning in libs.

@trofi trofi mentioned this pull request Jun 27, 2022
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants