zlib: backport upstream fix on CRC validation #177053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be a stdenv rebuild and needs to be (quietly) rebased onto the staging/master merge base and retargeted onto staging. |
ofborg
bot
added
10.rebuild-darwin-stdenv
SuperSandro2000
approved these changes
Jun 9, 2022
mweinelt
force-pushed
the
comprehensive-crc-validation-for-zlib
branch
from
069c275 to
a2b5dad
Compare
Starting zlib 1.2.12, CRC validation has became stricter. This broke Keycloak ≥ 17 in certain situations, for details, see: - keycloak/keycloak#11316 ; - NixOS#170539 This patch makes the CRC validation comprehensive with respect to older or already existing checksums out there.
mweinelt
force-pushed
the
comprehensive-crc-validation-for-zlib
branch
from
a2b5dad to
8335c46
Compare
SuperSandro2000
approved these changes
Jun 9, 2022
|
Builds on x86_64-linux and aarch64-linux. |
1 task
|
Successfully created backport PR #177107 for |
1 task
|
Successfully created backport PR #177108 for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Starting zlib 1.2.12, CRC validation has become stricter.
This broke Keycloak ≥ 17 in certain situations, for details, see:
This patch makes the CRC validation comprehensive with respect to older
or already existing checksums out there.
I suggest a backport to 22.05 as it is affected by this issue and we are guaranteed to see bug reports due to this.
I tested this patch on a "server system closure" containing Keycloak and much other stuff, but I do not have the hardware to perform the whole universe rebuild, it seems to be working.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes