pkgsCross.ppc64.libffi: pull patch to support gcc-12 #175914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mindavi
added
the
6.topic: cross-compilation
trofi
force-pushed
the
libffi-fix-for-gcc-12-powerpc64
branch
from
3bbb001 to
582867d
Compare
|
Made patch unconditional and inlined it to avoid |
| @@ -21,7 +16,13 @@ stdenv.mkDerivation rec { | |||
| sha256 = "081nx7wpzds168jbr59m34n6s3lyiq6r8zggvqxvlslsc4hvf3sl"; | |||
| }; | |||
|
|
|||
| patches = []; | |||
| # Note: this package is used for bootstrapping fetchurl, and thus | |||
There was a problem hiding this comment.
Better place but most other files have it at the top. Should be fine to change it though.
SuperSandro2000
approved these changes
Jun 2, 2022
trofi
changed the title
Without the change `libffi` fails to build against `gcc-12` as:
libtool: compile: powerpc64-unknown-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I. -I../include -Iinclude \
-I../src -O3 -fomit-frame-pointer -fstrict-aliasing -ffast-math -Wall -fexceptions -c ../src/tramp.c \
-fPIC -DPIC -o src/.libs/tramp.o
../src/powerpc/linux64_closure.S: Assembler messages:
../src/powerpc/linux64_closure.S:363: Error: unrecognized opcode: `lvx'
Co-authored-by: Sandro <[email protected]>
trofi
force-pushed
the
libffi-fix-for-gcc-12-powerpc64
branch
from
582867d to
55886c3
Compare
|
@ofborg eval |
ofborg
bot
added
10.rebuild-darwin-stdenv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the change
libffifails to build againstgcc-12as:Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes