cc-wrapper: Fortran: disable format hardening #174709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, these warnings are emitted: command-line option '-Wformat=1' is valid for C/C++/ObjC/ObjC++ but not for Fortran command-line option '-Wformat-security' is valid for C/C++/ObjC/ObjC++ but not for Fortran '-Werror=' argument '-Werror=format-security' is not valid for Fortran Fixes part of NixOS#27218
AtilaSaraiva
approved these changes
Jun 9, 2022
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Disable format hardening when compiling Fortran code.
Otherwise, these warnings are emitted:
command-line option '-Wformat=1' is valid for C/C++/ObjC/ObjC++ but not for Fortran
command-line option '-Wformat-security' is valid for C/C++/ObjC/ObjC++ but not for Fortran
'-Werror=' argument '-Werror=format-security' is not valid for Fortran
Fixes #27218
Things done
(done with this commit applied on master)
getdp(which previously failed) on platform(s)Not sure what else to do. This change shouldn't cause any regressions (cc.langFortran is only true for gfortran)..