Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grab-site: 2.2.0 -> 2.2.2; pythonPackages.ludios_wpull: 3.0.7 -> 3.0.9 #142826

Merged
merged 2 commits into from
Nov 20, 2021
Merged

grab-site: 2.2.0 -> 2.2.2; pythonPackages.ludios_wpull: 3.0.7 -> 3.0.9 #142826

merged 2 commits into from
Nov 20, 2021

Conversation

ivan
Copy link
Member

@ivan ivan commented Oct 25, 2021 •
edited
Loading

Motivation for this change

This updates grab-site, broken at runtime since 9974c90 when python3Packages.sqlalchemy was upgraded to 1.4 in nixpkgs.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ivan ivan requested review from FRidh and jonringer as code owners October 25, 2021 06:31
L-as
L-as approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@L-as L-as left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

L-as
L-as suggested changes Oct 28, 2021
View reviewed changes
Copy link
Member

@L-as L-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my latest comment.

@ivan
Copy link
Member Author

ivan commented Oct 28, 2021

@L-as thank you for the review. I have now introduced a sqlalchemy_1_3.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package and removed 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Oct 28, 2021
SuperSandro2000
SuperSandro2000 reviewed Nov 19, 2021
View reviewed changes
pkgs/development/python-modules/ludios_wpull/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/tools/backup/grab-site/default.nix Outdated Show resolved Hide resolved
pkgs/tools/backup/grab-site/default.nix Outdated Show resolved Hide resolved
ivan added 2 commits November 20, 2021 04:54
@ivan
grab-site: 2.2.0 -> 2.2.2; pythonPackages.ludios_wpull: 3.0.7 -> 3.0.9
b5e87f5 
Use SQLAlchemy 1.3 because ludios_wpull is incompatible with SQLAlchemy 1.4.

Use Python 3.8 instead of Python 3.7, as namedlist 1.8 fixed compatibility
with Python 3.8. We cannot use Python 3.9 until
ArchiveTeam/ludios_wpull#20 is fixed.
@ivan
python3Packages.ludios_wpull: use updated URLs
7769bdc 
https://github.com/ludios/wpull redirects to
https://github.com/ArchiveTeam/ludios_wpull
@SuperSandro2000 SuperSandro2000 merged commit 51d5630 into NixOS:master Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@L-as L-as L-as requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivan @SuperSandro2000 @symphorien @L-as