Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documentation of substring #12114

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

NaN-git
Copy link

@NaN-git NaN-git commented Dec 29, 2024

Motivation

Documents the actual behavior of builtins.substring.

Context

Fixes #12062


Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

Copy link
Contributor

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you very much!

@fricklerhandwerk fricklerhandwerk merged commit 968aabf into NixOS:master Dec 30, 2024
12 checks passed
@roberth roberth added backport 2.24-maintenance Automatically creates a PR against the branch backport 2.25-maintenance Automatically creates a PR against the branch labels Jan 10, 2025
mergify bot added a commit that referenced this pull request Jan 10, 2025
…2114

fix documentation of substring (backport #12114)
mergify bot added a commit that referenced this pull request Jan 10, 2025
…2114

fix documentation of substring (backport #12114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.24-maintenance Automatically creates a PR against the branch backport 2.25-maintenance Automatically creates a PR against the branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builltin string functions work on bytes, not characters
3 participants