Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipelines digest #447

Merged
merged 19 commits into from
Aug 25, 2023
Merged

Pipelines digest #447

merged 19 commits into from
Aug 25, 2023

Conversation

PierreGtch
Copy link
Collaborator

@PierreGtch PierreGtch marked this pull request as ready for review August 3, 2023 12:09
@bruAristimunha bruAristimunha requested a review from sylvchev August 4, 2023 09:07
@PierreGtch PierreGtch marked this pull request as draft August 4, 2023 12:32
@PierreGtch PierreGtch marked this pull request as ready for review August 4, 2023 13:55
sylvchev
sylvchev reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, pre/postprocessing pipelines are better integrated.

moabb/datasets/base.py Show resolved Hide resolved
moabb/datasets/base.py Show resolved Hide resolved
moabb/evaluations/base.py Outdated Show resolved Hide resolved
moabb/tests/benchmark.py Show resolved Hide resolved
sylvchev
sylvchev reviewed Aug 17, 2023
View reviewed changes
moabb/datasets/base.py Outdated Show resolved Hide resolved
@bruAristimunha
Copy link
Collaborator

Can we merge @sylvchev?

@sylvchev sylvchev merged commit adce413 into NeuroTechX:develop Aug 25, 2023
@sylvchev
Copy link
Member

Yes, thanks @PierreGtch !

@dcwil dcwil mentioned this pull request Dec 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvchev sylvchev sylvchev left review comments

@bruAristimunha bruAristimunha Awaiting requested review from bruAristimunha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compute digest from the full processing+classification pipeline
3 participants
@PierreGtch @bruAristimunha @sylvchev