Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark function #264

Merged
merged 39 commits into from
Jan 2, 2023
Merged

Benchmark function #264

merged 39 commits into from
Jan 2, 2023

Conversation

Div12345
Copy link
Collaborator

@Div12345 Div12345 commented Feb 9, 2022 •
edited by sylvchev
Loading

@sylvchev I added an extra print statement after the debug log of the datasets so that it can be visible in the usual output as well as being logged. Let me know if you think it seems unnecessary, if so I could remove it.

TODO -

  • Add an example
  • Run the example as well as the run.py once to make sure they work as expected (Haven't done because I don't have the datasets)
  • Adding test for benchmark, _inc_exc_datasets; maybe for parse_pipelines_from_directory and generate_paradigms
  • what's new

@Div12345 Div12345 requested a review from sylvchev February 28, 2022 12:18
sylvchev
sylvchev requested changes Mar 2, 2022
View reviewed changes
Copy link
Member

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could really be useful to have include_datasets and exclude_datasets parameter to allow to run benchmarks on selected subset of datasets.

@Div12345 Div12345 requested a review from sylvchev March 6, 2022 09:39
sylvchev
sylvchev requested changes Mar 17, 2022
View reviewed changes
moabb/benchmark.py Outdated Show resolved Hide resolved
moabb/benchmark.py Outdated Show resolved Hide resolved
moabb/benchmark.py Outdated Show resolved Hide resolved
@sylvchev
Copy link
Member

sylvchev commented Mar 17, 2022 •
edited
Loading

Running some tests:

  • include_dataset works with code and object
  • plot
  • multiple evaluation
  • filterbank and singlepass restults are combined

Div12345 and others added 15 commits November 13, 2022 22:38
@Div12345
whatsnew and remove MI result combo
0860dc8 
- Updating whats new
- Removing MotorImagery for combination of Filterbank and Single Pass results
@Div12345
Merge branch 'develop' into benchmark
4fcd322
@Div12345
Copy link
Collaborator Author

@sylvchev I think the combination of FB and SinglePass results is also done Line
If I remember correctly this shouldn't be done in case of MI.

Div12345 and others added 4 commits November 14, 2022 17:48
@Div12345
Adding select_paradigms
94ee23f 
Using an exception for flake8 function too complex error. May want to find a better implementation and remove exception.
@Div12345
rectify select_paradigms implementation
1c2f134
@sylvchev
Merge branch 'develop' into benchmark
d72bdd7
fix error when select_paradigms is None
5415bb5
Sylvain Chevallier added 17 commits December 31, 2022 18:41
@sylvchev
Copy link
Member

sylvchev commented Jan 2, 2023

Ready to merge !

@sylvchev sylvchev merged commit ae9f7c7 into NeuroTechX:develop Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvchev sylvchev sylvchev approved these changes

Assignees

@sylvchev sylvchev

@Div12345 Div12345

Labels
documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Div12345 @sylvchev