Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect event name in Shin2017B #388

Closed
PierreGtch opened this issue May 28, 2023 · 1 comment
Closed

Incorrect event name in Shin2017B #388

PierreGtch opened this issue May 28, 2023 · 1 comment
Labels
bug dataset Supporting new dataset

Comments

@PierreGtch
Copy link
Collaborator

In Shin2017B, an event is named substraction, but should be named subtraction (like in BNCI2015004).
@sylvchev
Copy link
Member

sylvchev commented Jun 1, 2023

Yes, good catch. Could you push a small PR?
Futhermore, this Shin2017B dataset should be in MotorImagery. We are considering the possibility to add passive BCI datasets by creating a new paradigm. This new passive BCI paradigm will be a better home for this dataset.

@sylvchev sylvchev added bug dataset Supporting new dataset labels Jun 1, 2023
PierreGtch added a commit to PierreGtch/moabb that referenced this issue Jun 2, 2023
@PierreGtch
Rename event in Shin2017B - Fixes NeuroTechX#388
384067b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug dataset Supporting new dataset
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sylvchev @PierreGtch